Skip to content
Snippets Groups Projects

Update Repos.csv with Ziyang Fang's project information

Merged Ziyang Fang requested to merge fangz58/cas741:master into master
1 unresolved thread
  • Added Ziyang Fang's project information to the Repos.csv file.
  • Included:
    • GitHub ID: fangz58
    • Supervisor: Dr. Smith
    • Project Topic: Traditional Development
  • Please review and approve.

Merge request reports

Approval is optional

Merged by W. Spencer SmithW. Spencer Smith 3 months ago (Jan 15, 2025 1:09am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • You have a merge conflict because you are 3 commits behind the main branch. You should always git pull before starting to edit to the file. You can either fix this pull request, or close it and start a new one.

  • Ziyang Fang added 4 commits

    added 4 commits

    Compare with previous version

  • Author Contributor

    Thank you for the feedback, Dr. Smith. I did run git pull before making changes, but I realize now that the issue occurred because my forked repository was not up-to-date with the upstream repository. I have since fetched the latest changes from the upstream repository, resolved the merge conflict, and updated my fork. I will ensure to regularly synchronize my forked repository with the upstream repository to avoid such issues in the future.

  • mentioned in commit 68a259a2

    • @fangz58, Thank you for the fixes. I merged the pull request so you can hold your spot in the file (this is easier to avoid future merge conflicts). However, I would like you to make some changes, as follows:

      • your github id should just be your github user name. It isn't usually a number
      • I probably agree that your project is a research project, but I'd like you to include an extra for now, just in case we need it
      • for domain expert, remove Dr. Giamou and put TBD. You are right that Dr. Giamou is an expert, but we actually use this column to identify the classmate that will be reviewing your work
    • Author Contributor

      Thank you for your guidance, Dr. Smith. I have updated the Repos.csv file with the corrected GitHub ID and domain expert reviewer as per your suggestions. Please review the changes at your convenience. The search I did last night to find the githubId was this one: https://stackoverflow.com/questions/17308954/where-can-i-find-the-github-id-in-my-account. Then I got the numbers as a result

    • Please register or sign in to reply
  • Author Contributor

    Thank you, Dr. Smith, for your feedback and for merging the pull request. I just saw your message—apologies for the delay. I will make the necessary changes right away. I show refer to the first row as an example to update my GitHub ID and domain expert reviewer. I now understand what TBD means, and I appreciate your clarification. Thank you again for your guidance!

Please register or sign in to reply
Loading